Skip to content

Commit

Permalink
add tests
Browse files Browse the repository at this point in the history
  • Loading branch information
smellycloud committed Oct 28, 2024
1 parent 81af531 commit 313cec2
Show file tree
Hide file tree
Showing 2 changed files with 67 additions and 19 deletions.
38 changes: 19 additions & 19 deletions meta_tools/tests/test_ensemble_scaffold_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -257,26 +257,26 @@ def test_assess_ensemble_scripts(temp_dir, mock_ensemble_path):
# assert assessment["structure_errors"] == {temp_dir / "test_ensemble" / "subdir1"}


# def test_assess_ensemble_scripts_with_missing_scripts(temp_dir, mock_ensemble_path):
# """
# Test the `assess_model_scripts` method with missing scripts.
def test_assess_ensemble_scripts_with_missing_scripts(temp_dir, mock_ensemble_path):
"""
Test the `assess_model_scripts` method with missing scripts.
# Args:
# temp_dir (Path): The path to the temporary directory.
# mock_ensemble_path (MagicMock): The mock object for `EnsemblePath`.
Args:
temp_dir (Path): The path to the temporary directory.
mock_ensemble_path (MagicMock): The mock object for `EnsemblePath`.
# Asserts:
# - The script assessment detects missing scripts.
# """
# mock_ensemble_instance = mock_ensemble_path.return_value
# mock_ensemble_instance.model_dir = temp_dir / "test_ensemble"
# mock_ensemble_instance.get_scripts.return_value = {
# "script1": temp_dir / "test_ensemble" / "script1.py"
# }
Asserts:
- The script assessment detects missing scripts.
"""
mock_ensemble_instance = mock_ensemble_path.return_value
mock_ensemble_instance.model_dir = temp_dir / "test_ensemble"
mock_ensemble_instance.get_scripts.return_value = {
"script1": temp_dir / "test_ensemble" / "script1.py"
}

# builder = EnsembleScaffoldBuilder("test_ensemble")
# builder.build_model_directory()
builder = EnsembleScaffoldBuilder("test_ensemble")
builder.build_model_directory()

# with patch('ensemble_scaffold_builder.Path.exists', side_effect=[True, False, True, True]):
# assessment = builder.assess_model_scripts()
# assert assessment["missing_scripts"] == {temp_dir / "test_ensemble" / "script1.py"}
with patch('ensemble_scaffold_builder.Path.exists', side_effect=[True, False, True, True]):
assessment = builder.assess_model_scripts()
assert assessment["missing_scripts"] == {temp_dir / "test_ensemble" / "script1.py"}
48 changes: 48 additions & 0 deletions meta_tools/tests/test_model_scaffold_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,3 +239,51 @@ def test_assess_model_scripts(mock_input, temp_dir, mock_model_path):

assert "missing_scripts" in assessment
assert assessment["missing_scripts"]

# def test_assess_model_directory_with_missing_dirs(temp_dir, mock_model_path):
# """
# Test the `assess_model_directory` method with missing directories.

# Args:
# temp_dir (Path): The path to the temporary directory.
# mock_model_path (MagicMock): The mock object for `ModelPath`.

# Asserts:
# - The directory assessment detects missing directories.
# """
# mock_model_instance = mock_model_path.return_value
# mock_model_instance.model_dir = temp_dir / "test_model"
# mock_model_instance.get_directories.return_value = {
# "subdir1": temp_dir / "test_model" / "subdir1"
# }

# builder = ModelScaffoldBuilder("test_model")
# builder.build_model_directory()

# with patch('model_scaffold_builder.Path.exists', side_effect=[True, False, True]):
# assessment = builder.assess_model_directory()
# assert assessment["structure_errors"] == {temp_dir / "test_model" / "subdir1"}

def test_assess_model_scripts_with_missing_scripts(temp_dir, mock_model_path):
"""
Test the `assess_model_scripts` method with missing scripts.
Args:
temp_dir (Path): The path to the temporary directory.
mock_model_path (MagicMock): The mock object for `ModelPath`.
Asserts:
- The script assessment detects missing scripts.
"""
mock_model_instance = mock_model_path.return_value
mock_model_instance.model_dir = temp_dir / "test_model"
mock_model_instance.get_scripts.return_value = {
"script1": temp_dir / "test_model" / "script1.py"
}

builder = ModelScaffoldBuilder("test_model")
builder.build_model_directory()

with patch('model_scaffold_builder.Path.exists', side_effect=[True, False, True, True]):
assessment = builder.assess_model_scripts()
assert assessment["missing_scripts"] == {temp_dir / "test_model" / "script1.py"}

0 comments on commit 313cec2

Please sign in to comment.