Skip to content

Commit

Permalink
Shadow improvements for resting shadows (#1187)
Browse files Browse the repository at this point in the history
* update buttons

* Update resting shadows

* improve resting med
  • Loading branch information
lukasoppermann authored Feb 19, 2025
1 parent 9802c5b commit 4266174
Show file tree
Hide file tree
Showing 3 changed files with 52 additions and 14 deletions.
5 changes: 5 additions & 0 deletions .changeset/tasty-games-love.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/primitives': patch
---

Update resting shadow values
8 changes: 4 additions & 4 deletions src/tokens/component/button.json5
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
},
},
},
shadow: {
shadow: {
resting: {
$value: [
{
Expand Down Expand Up @@ -479,7 +479,7 @@
},
},
},
shadow: {
shadow: {
selected: {
$value: [
{
Expand Down Expand Up @@ -982,7 +982,7 @@
},
},
},
shadow: {
shadow: {
selected: {
$value: [
{
Expand Down Expand Up @@ -1289,7 +1289,7 @@
},
},
},
shadow: {
shadow: {
selected: {
$value: [
{
Expand Down
53 changes: 43 additions & 10 deletions src/tokens/functional/shadow/shadow.json5
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@
xsmall: {
$value: {
color: '{base.color.neutral.13}',
alpha: 0.1,
alpha: 0.06,
offsetX: '0px',
offsetY: '1px',
blur: '0px',
blur: '1px',
spread: '0px',
inset: false,
},
Expand All @@ -55,7 +55,7 @@
alpha: 0.8,
offsetX: '0px',
offsetY: '1px',
blur: '0px',
blur: '1px',
spread: '0px',
inset: false,
},
Expand All @@ -67,10 +67,19 @@
$value: [
{
color: '{base.color.neutral.13}',
alpha: 0.04,
alpha: 0.06,
offsetX: '0px',
offsetY: '1px',
blur: '0px',
blur: '1px',
spread: '0px',
inset: false,
},
{
color: '{base.color.neutral.13}',
alpha: 0.06,
offsetX: '0px',
offsetY: '1px',
blur: '3px',
spread: '0px',
inset: false,
},
Expand All @@ -86,10 +95,19 @@
$value: [
{
color: '{base.color.neutral.0}',
alpha: 0.4,
alpha: 0.6,
offsetX: '0px',
offsetY: '1px',
blur: '0px',
blur: '1px',
spread: '0px',
inset: false,
},
{
color: '{base.color.neutral.0}',
alpha: 0.6,
offsetX: '0px',
offsetY: '1px',
blur: '3px',
spread: '0px',
inset: false,
},
Expand All @@ -100,6 +118,14 @@
},
medium: {
$value: [
{
color: '{base.color.neutral.12}',
alpha: 0.1,
offsetX: '0px',
offsetY: '1px',
blur: '1px',
spread: '0px',
},
{
color: '{base.color.neutral.12}',
alpha: 0.12,
Expand All @@ -118,6 +144,14 @@
'org.primer.overrides': {
dark: {
$value: [
{
color: '{base.color.neutral.0}',
alpha: 0.4,
offsetX: '0px',
offsetY: '1px',
blur: '1px',
spread: '0px',
},
{
color: '{base.color.neutral.0}',
alpha: 0.8,
Expand Down Expand Up @@ -414,8 +448,7 @@
],
$type: 'shadow',
$extensions: {
'org.primer.figma': {
},
'org.primer.figma': {},
'org.primer.overrides': {
dark: {
$value: [
Expand All @@ -442,4 +475,4 @@
},
},
},
}
}

0 comments on commit 4266174

Please sign in to comment.