-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add igorshubovych/markdownlint-cli to hooks page #1008
base: main
Are you sure you want to change the base?
Conversation
so I notice there's also https://github.com/DavidAnson/markdownlint-cli2 which appears to be written by the author of the underlying library |
I also saw that. I’m not sure the differences between them. But I see Anson
is a regular contributor to the other one which has more than 500 stars
which is a requirement to be listed on the pre-commit hook page. Cli2 has
less than 500 stars.
|
I'd be more comfortable understanding the differences between choosing one for this page |
A summary of the differences is here.
A more detailed explanation is on Anson's blog here. He writes it's faster, config is more flexible, and fewer dependencies. Based on this, I think listing Anson's is better. What do you think? |
gentle bump |
I mean yeah seems fine |
Thanks! Let me know next steps, if any, to get this merged. |
hmm I'm confused -- is your conclusion above that the |
The current Markdownlint hook is in Ruby. Mention a popular Node-based one as well. Signed-off-by: David Xia <david@davidxia.com>
Oh, sorry. Forgot to update the PR. Updated now with 2. |
The current Markdownlint hook is in Ruby.
Mention a popular Node-based one as well.