New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for config and wrong sensor #7

Merged

poolski merged 1 commit into poolski:main from FabFaeb:main

Oct 9, 2024

Contributor

FabFaeb commented Apr 30, 2024

Hi there and thanks for the cool tool!
I tried to use it and had some minor issues I tried to fix with this PR:

the config was not generated correctly, as already mentioned in Config is created with entry "sensor" but actually expects "sensor_id" #6
when a wrong sensorID is entered, the tool runs into an index out of bounds error in line changeSlice[j] = data.Result[sensorID][j].Change which I tried to detect preemptively

Let me know if there something seems wrong to you!

Again thanks for providing this!


          minor fixes

39f080b

poolski approved these changes

View reviewed changes

Owner

poolski left a comment

Nice one! Thank you for fixing these! 🙇🏻

poolski merged commit 04f91cf into poolski:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet