Fix bugs and add basic tests #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
poolski
commented
Apr 10, 2024
poolski
commented
- Run release action on multiple platforms in parallel
- Refactor code to make it a bit more testable
- Add some basic tests
- Support arbitrary sensor IDs properly
The previous implementation of the Result type assumed a specific sensor ID would be present when unmarshaling JSON, which isn't always going to be the case. This approach converts the type into an anonymous struct which properly supports us setting a custom sensor ID for incoming power.
poolski
force-pushed
the
refactor-and-add-tests
branch
from
43f8370 to
3839fe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.