Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to prove block ranges for GRANDPA #391

Merged
merged 10 commits into from
Mar 3, 2025

Conversation

seunlanlege
Copy link
Member

@seunlanlege seunlanlege commented Feb 28, 2025

The grandpa_proveFinality seems to return proofs only for the latest finalized height instead of for blocks within the epoch. This updates the prover to only prove blocks within the requested range

Copy link
Member

@Wizdave97 Wizdave97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seunlanlege
Copy link
Member Author

From my experiments proving block ranges is quite slow and should be avoided if possible

@seunlanlege seunlanlege merged commit 3c1a7e1 into main Mar 3, 2025
7 checks passed
@seunlanlege seunlanlege deleted the seun/grandpa-prover-max-range branch March 3, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants