refactor(rust): Avoid downloading full parquet when initializing new streaming parquet source #21580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
nameexhaustion
commented
Mar 4, 2025
| // * This is also downloading the whole file even if there is a projection | ||
| let memslice = source | ||
| .as_scan_source_ref() | ||
| .to_memslice_async_assume_latest(source.run_async())?; |
There was a problem hiding this comment.
We download for IPC, but this is also what we do in the in-memory engine as well
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21580 +/- ##
==========================================
+ Coverage 79.43% 79.47% +0.03%
==========================================
Files 1602 1602
Lines 230574 230778 +204
Branches 2636 2639 +3
==========================================
+ Hits 183164 183401 +237
+ Misses 46799 46765 -34
- Partials 611 612 +1 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
ritchie46
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.