Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Use a oneshot channel for unrestricted_row_count, fix panic in new-streaming negative slice #21559

Merged

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Mar 3, 2025

Instead of an atomic integer, this ensures we explicitly block until the source has sent the final row count.

Also fixes a panic in new-streaming negative slice on empty morsel inputs.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Mar 3, 2025
@nameexhaustion nameexhaustion changed the title refactor(rust): Use a oneshot channel for unrestricted_row_count refactor(rust): Use a oneshot channel for unrestricted_row_count, fix panic in new-streaming negative slice Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (2ae7287) to head (50b907c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/negative_slice.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21559      +/-   ##
==========================================
+ Coverage   79.75%   79.82%   +0.06%     
==========================================
  Files        1591     1591              
  Lines      229480   229494      +14     
  Branches     2625     2625              
==========================================
+ Hits       183018   183185     +167     
+ Misses      45857    45704     -153     
  Partials      605      605              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review March 3, 2025 08:00
@ritchie46 ritchie46 merged commit 2eae41d into pola-rs:main Mar 3, 2025
31 checks passed
anath2 pushed a commit to anath2/polars that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants