Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Categorical min/max panicking when string cache is enabled #21552

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

lukemanley
Copy link
Contributor

Fixes the following panic:

import polars as pl

pl.enable_string_cache()

pl.Series(["a", "b"], dtype=pl.Categorical()).min()
# pyo3_runtime.PanicException: internal error: entered unreachable code

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 1, 2025
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.82%. Comparing base (b93b97b) to head (c85e3dc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21552   +/-   ##
=======================================
  Coverage   79.82%   79.82%           
=======================================
  Files        1591     1591           
  Lines      229477   229477           
  Branches     2625     2625           
=======================================
+ Hits       183170   183178    +8     
+ Misses      45702    45694    -8     
  Partials      605      605           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Thanks!

@ritchie46 ritchie46 merged commit 8f9e360 into pola-rs:main Mar 2, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants