Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add len method to arr #21513

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: Add len method to arr #21513

wants to merge 7 commits into from
+96 −0

Conversation

teomac
Copy link

@teomac teomac commented Feb 27, 2025

This PR adds the len method to arr.

This is the first part working on this issue: #21302

@teomac teomac changed the title feat: add len method to arr feat: Add len method to arr Feb 27, 2025
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Feb 27, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.22222% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.68%. Comparing base (e801b83) to head (37d1dfb).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/dsl/function_expr/array.rs 61.53% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #21513      +/-   ##
==========================================
- Coverage   79.81%   79.68%   -0.13%     
==========================================
  Files        1592     1604      +12     
  Lines      229266   231555    +2289     
  Branches     2623     2639      +16     
==========================================
+ Hits       182991   184524    +1533     
- Misses      45670    46422     +752     
- Partials      605      609       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teomac teomac marked this pull request as draft February 28, 2025 07:01
@teomac teomac marked this pull request as ready for review March 4, 2025 07:30
@teomac teomac requested a review from ritchie46 March 4, 2025 09:55
@teomac teomac requested a review from coastalwhite March 4, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@coastalwhite coastalwhite Awaiting requested review from coastalwhite

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teomac @ritchie46 @coastalwhite