Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Improve hash join build sample implementation #21236

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Feb 13, 2025

Small things like not holding on to memory, respecting stop requests, not letting multiple values in single pipeline, etc, and cleaned up code.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 208 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (9bcff72) to head (62d5534).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/joins/equi_join.rs 0.00% 208 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21236      +/-   ##
==========================================
+ Coverage   79.75%   79.86%   +0.10%     
==========================================
  Files        1593     1596       +3     
  Lines      228119   228463     +344     
  Branches     2600     2607       +7     
==========================================
+ Hits       181947   182455     +508     
+ Misses      45575    45412     -163     
+ Partials      597      596       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 918bb1a into pola-rs:main Feb 13, 2025
22 checks passed
@c-peters c-peters added the accepted Ready for implementation label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants