Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Projection of only row index in new streaming IPC #21167

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix: Projection of only row index in new streaming IPC #21167

merged 1 commit into from
Feb 10, 2025

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 10, 2025
@coastalwhite coastalwhite force-pushed the fix/new-streaming-ipc-row-index-projection branch from 4cca1d1 to aecb65a Compare February 10, 2025 14:48
@codecov Codecov
Copy link

codecov bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.88%. Comparing base (b50f758) to head (aecb65a).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/io_sources/ipc.rs 92.85% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #21167   +/-   ##
=======================================
  Coverage   79.88%   79.88%           
=======================================
  Files        1593     1593           
  Lines      227649   227640    -9     
  Branches     2600     2600           
=======================================
- Hits       181858   181851    -7     
+ Misses      45194    45192    -2     
  Partials      597      597

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite merged commit d15bfe5 into pola-rs:main Feb 10, 2025
27 checks passed
@coastalwhite coastalwhite deleted the fix/new-streaming-ipc-row-index-projection branch February 10, 2025 15:10
braaannigan pushed a commit to braaannigan/polars that referenced this pull request Feb 12, 2025
@coastalwhite
fix: Projection of only row index in new streaming IPC (pola-rs#21167)
e982c8e
@c-peters c-peters added the accepted Ready for implementation label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees

@coastalwhite coastalwhite

Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coastalwhite @c-peters