Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Add dedicated concatenate kernels #21080

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Feb 4, 2025

This mainly speeds up our rechunks, previously this went through the generic make_growable interface which isn't as efficient with getting the allocation sizes correct, and was also unnecessarily copying string data for ViewArrays. EDIT: doing lazy string copying slowed down the new-streaming engine due to an excessive amount of buffers in the string view, so that's disabled for now.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Feb 4, 2025
@orlp orlp marked this pull request as draft February 4, 2025 16:51
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 83.06011% with 62 lines in your changes missing coverage. Please review.

Project coverage is 79.25%. Comparing base (3336475) to head (afe55b8).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-arrow/src/compute/concatenate.rs 84.19% 55 Missing ⚠️
crates/polars-arrow/src/array/values.rs 0.00% 2 Missing ⚠️
crates/polars-core/src/chunked_array/from.rs 0.00% 2 Missing ⚠️
crates/polars-arrow/src/legacy/array/list.rs 0.00% 1 Missing ⚠️
crates/polars-core/src/series/from.rs 0.00% 1 Missing ⚠️
crates/polars-json/src/ndjson/deserialize.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21080      +/-   ##
==========================================
+ Coverage   79.20%   79.25%   +0.05%     
==========================================
  Files        1586     1585       -1     
  Lines      225648   225985     +337     
  Branches     2588     2588              
==========================================
+ Hits       178714   179100     +386     
+ Misses      46344    46295      -49     
  Partials      590      590              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp marked this pull request as ready for review February 4, 2025 21:11
@ritchie46 ritchie46 merged commit 78cc260 into pola-rs:main Feb 5, 2025
23 checks passed
@c-peters c-peters added the accepted Ready for implementation label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants