perf: Add dedicated concatenate kernels #21080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly speeds up our rechunks, previously this went through the generic
make_growable
interface which isn't as efficient with getting the allocation sizes correct, and was alsounnecessarily copying string data for. EDIT: doing lazy string copying slowed down the new-streaming engine due to an excessive amount of buffers in the string view, so that's disabled for now.ViewArray
s