fix: Csv stop simd cache if eol char is hit #20199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
ritchie46
commented
Dec 6, 2024
| @@ -404,6 +404,8 @@ impl<'a> CoreReader<'a> { | |||
|
|
|||
| let counter = CountLines::new(self.quote_char, self.eol_char); | |||
| let mut total_offset = 0; | |||
| let check_utf8 = matches!(self.encoding, CsvEncoding::Utf8) | |||
There was a problem hiding this comment.
take this out of the loop
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20199 +/- ##
=======================================
Coverage 79.63% 79.63%
=======================================
Files 1564 1564
Lines 217804 217809 +5
Branches 2477 2477
=======================================
+ Hits 173439 173453 +14
+ Misses 43796 43787 -9
Partials 569 569 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the flaky test