Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Purge unused code #19267

Merged
merged 4 commits into from
Oct 17, 2024
Merged

refactor(rust): Purge unused code #19267

merged 4 commits into from
Oct 17, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 16, 2024

No description provided.

@orlp orlp marked this pull request as ready for review October 16, 2024 21:44
@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.11%. Comparing base (20ead46) to head (bb3ec53).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/dsl/function_expr/pow.rs 31.25% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19267      +/-   ##
==========================================
+ Coverage   80.03%   80.11%   +0.08%     
==========================================
  Files        1528     1526       -2     
  Lines      209657   209330     -327     
  Branches     2416     2416              
==========================================
- Hits       167791   167707      -84     
+ Misses      41317    41074     -243     
  Partials      549      549              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 16, 2024

CodSpeed Performance Report

Merging #19267 will improve performances by 25.14%

Comparing orlp:unused-purge (bb3ec53) with main (3255066)

Summary

⚡ 1 improvements
✅ 40 untouched benchmarks

Benchmarks breakdown

Benchmark main orlp:unused-purge Change
test_groupby_h2oai_q5 2.7 ms 2.1 ms +25.14%

@ritchie46 ritchie46 merged commit b9a4e68 into pola-rs:main Oct 17, 2024
23 checks passed
@c-peters c-peters added the accepted Ready for implementation label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants