Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Improve hypothesis strategy for decimals #16001

Merged
merged 6 commits into from
May 2, 2024

Conversation

stinodego
Copy link
Contributor

@stinodego stinodego commented May 2, 2024

It's now possible to supply a precision/scale and the proper decimal values will be generated.

I also set up the dtype_strategies strategy which will be key to upgrading the list/array strategies (these need to be converted to a composite strategy).

Next step will be to set up a dtypes strategy which generates a random Polars data type. This will be used by the list/array strategies. Then I will upgrade the list/array strategies and we can finally upgrade to the latest hypothesis version.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 65.51724% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 80.89%. Comparing base (c3c5bef) to head (2a025d7).

Files Patch % Lines
py-polars/polars/testing/parametric/strategies.py 64.28% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16001      +/-   ##
==========================================
- Coverage   80.91%   80.89%   -0.02%     
==========================================
  Files        1384     1384              
  Lines      178112   178132      +20     
  Branches     3043     3050       +7     
==========================================
- Hits       144113   144107       -6     
- Misses      33515    33537      +22     
- Partials      484      488       +4     
Flag Coverage Δ
python 74.37% <65.51%> (-0.03%) ⬇️
rust 78.11% <31.03%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review May 2, 2024 06:52
@stinodego stinodego merged commit 5062732 into main May 2, 2024
15 checks passed
@stinodego stinodego deleted the hypothesis-dtype branch May 2, 2024 07:05
@alexander-beedie
Copy link
Collaborator

Nice :)

AlexanderNenninger pushed a commit to AlexanderNenninger/polars that referenced this pull request May 3, 2024
@c-peters c-peters added the accepted Ready for implementation label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants