Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Index Column of Type Duration in DataFrame.rolling #15999

Closed
wants to merge 27 commits into from
Closed

Allow Index Column of Type Duration in DataFrame.rolling #15999

wants to merge 27 commits into from

Conversation

AlexanderNenninger
Copy link

Implements #14764. Exactly what the title states, the implementation is almost a copy of the one for integer indices. I added a few extra tests to ensure compatible behavior with DateTime.

@AlexanderNenninger
Copy link
Author

What the heck? Codecov token not found??: https://github.com/pola-rs/polars/actions/runs/8913916408/job/24480392846?pr=15999

alexander-beedie and others added 12 commits May 3, 2024 12:08
@alexander-beedie @Nennia
feat: Additional uint datatype support for the SQL interface (pola-…
c5d92ec 
…rs#15993)
@nameexhaustion @Nennia
fix: Crash/incorrect group_by/n_unique on categoricals created by (q)…
1498a37 
…cut (pola-rs#16006)
@stinodego @Nennia
test(python): Improve hypothesis strategy for decimals (pola-rs#16001)
cbbb8c8
@Nennia
docs(python): Improve user-guide doc of UDF (pola-rs#15923)
63a2af6
@ritchie46 @Nennia
refactor: Add some comments (pola-rs#16008)
aa46fef
@ritchie46 @Nennia
feat: Improve dynamic supertypes (pola-rs#16009)
f0d81b7
@MarcoGorelli @Nennia
docs(python): correct default in rolling_* function examples (pola-rs…
d6306be 
…#16000)
@ritchie46 @Nennia
fix: Fix CSE case where upper plan has no projection (pola-rs#16011)
19e7548
@orlp @Nennia
fix: properly handle nulls in DictionaryArray::iter_typed (pola-rs#16013
24c8fe1 
)
@bertiewooster @Nennia
docs(python): Remove unwanted linebreaks from docstrings (pola-rs#16002)
28373f0
@ritchie46 @Nennia
feat: Convert concat during IR conversion (pola-rs#16016)
31a019f
@MarcoGorelli @Nennia
feat: raise more informative error messages in rolling_* aggregations…
4f8e1dc 
… instead of panicking (pola-rs#15979)
@AlexanderNenninger
Copy link
Author

Guess this won’t happen then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@universalmind303 universalmind303 Awaiting requested review from universalmind303

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@AlexanderNenninger @MarcoGorelli @Nennia @alexander-beedie @nameexhaustion @stinodego @ritchie46 @orlp @bertiewooster @avimallu