Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Update reference to apply #15982

Merged
merged 3 commits into from
May 3, 2024
Merged

Conversation

avimallu
Copy link
Contributor

@avimallu avimallu commented May 1, 2024

Closes #15945.

Removed the reference to apply as indicated and replaced with map_rows or map_elements as appropriate.

Removed the reference to `apply` as indicated in #15945 and replaced with `map_rows` or `map_elements` as appropriate.
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels May 1, 2024
@avimallu
Copy link
Contributor Author

avimallu commented May 1, 2024

Test failures unrelated to this PR: Ruff job failed to setup and Code Coverage failed with the error:

Codecov: Failed to properly create commit: The process '/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

@alexander-beedie
Copy link
Collaborator

alexander-beedie commented May 1, 2024

Removed the reference to apply as indicated and replaced with map_rows or map_elements as appropriate.

Nice one; you receive today's "Eye of the Tiger" award 😁🏆

Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh; just to be sure I re-ran the failing ruff lint job and one small fix is required ;)

py-polars/polars/dataframe/frame.py:6202:89: 
  W505 Doc line too long (89 > 88)

@avimallu
Copy link
Contributor Author

avimallu commented May 1, 2024

you receive today's "Eye of the Tiger" award 😁🏆

Haha, full credit goes to @david-waterworth though :)

one small fix is required ;)

Nice catch, have made the update.

Code coverage seems to require a token now, so I guess that will fail until then.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (80233b8) to head (656c422).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15982   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files        1384     1384           
  Lines      178111   178111           
  Branches     3043     3043           
=======================================
+ Hits       144112   144120    +8     
+ Misses      33515    33506    -9     
- Partials      484      485    +1     
Flag Coverage Δ
python 74.41% <ø> (+0.02%) ⬆️
rust 78.05% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-beedie alexander-beedie merged commit a3efd8c into pola-rs:main May 3, 2024
13 checks passed
@alexander-beedie
Copy link
Collaborator

Thank you both! ✌️

AlexanderNenninger pushed a commit to AlexanderNenninger/polars that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame.map_rows mentions apply
2 participants