feat(python): Improve write_database
, accounting for latest adbc
fixes/updates
#12713
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12684.
Ref: #10763, #11282 (comment).
Enhancements
Updates
pl.write_database
and associated tests with various improvements now that some key issues (apache/arrow-adbc#1000, apache/arrow-adbc#1109) have been resolved in the ADBC0.7
and0.8
releases, respectively.schema.table_name
).if_exists = "fail"
(simulated).if_exists = "replace"
(native).3.12
.Requires that the caller has installed at least ADBC version
0.7
for "replace" support, or0.8
if using schema-qualified names, as these versions contain the related/required fixes (if not doing either of these things earlier versions of ADBC continue to work fine).Note
In addition to SQLite (what we run in CI), I was able to validate these updates against a local PostgreSQL instance.