feat: arbitrary sized circuits #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonerapier
force-pushed
the
feat/arbitrary-sized-circuits
branch
from
fab752c to
69ebdd7
Compare
lonerapier
requested review from
Autoparallel,
devloper,
piotr-roslaniec and
0xJepsen
Autoparallel
reviewed
Feb 6, 2025
| // both should be 0 or 1 together | ||
| signal is_new_state_digest_zero <== IsEqual()([new_state_digest, 0]); | ||
| signal is_step_out_zero_matched <== IsEqual()([step_out[0], value_digest]); | ||
| 0 === is_new_state_digest_zero - is_step_out_zero_matched; // verify final value matches |
Autoparallel
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
I am quite familiar with most of these changes and the tests of the circom circuits seem to imply this is functioning correctly as far as we can tell. Likewise, it is working with the Rust witness generation tooling.
I have no issue merging this. It has my greenlight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #90
TODO:
circuit diagram: https://miro.com/app/board/uXjVLVedPM8=/
