Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the lisp image and references to it #4455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danmilon
Copy link
Contributor

@danmilon danmilon commented Mar 6, 2025

See IMG-1954: fully drop the lisp image.

The image is not used at all, so lets sunset it to reduce maintenance cost.

@danmilon danmilon force-pushed the img-1954-fully-drop-the-lisp-image branch from eb42e5c to 2456949 Compare March 6, 2025 14:18
@flovntp flovntp added the build-fork To build PRs from forks label Mar 7, 2025
@flovntp
Copy link
Contributor

flovntp commented Mar 7, 2025

Hey @danmilon
i think you miss the recent split between single-runtime and Composable image.
This page still reference Lisp (and same on Upsun side).
Could you please also modify the composable-image.md files on both Upsun and P.sh?
https://github.com/platformsh/platformsh-docs/blob/main/sites/platform/src/create-apps/app-reference/composable-image.md?plain=1#L121

I would be happy to contribute to your branch, but it's a fork and i can't :D

ps:

@flovntp
Copy link
Contributor

flovntp commented Mar 7, 2025

or maybe i'm wrong and using Composable image, Common Lisp (SBCL) is still supported.
If that's the case, i would gladly approve you PR ;)

@danmilon
Copy link
Contributor Author

danmilon commented Mar 7, 2025

yeah at the moment there's one production use of lisp on the composable image, and it's supposed to be supported. I think it makes sense to keep this one for now.

@flovntp
Copy link
Contributor

flovntp commented Mar 7, 2025

Last thing, could you please remove the link in the composable-image.md files (Upsun and P.sh) to the lisp page?

  target does not exist --- create-apps/app-reference/composable-image.html --> /languages/lisp.html

@danmilon
Copy link
Contributor Author

danmilon commented Mar 7, 2025

ah I see. so the composable image pages link to the single-runtime pages? But if we remove the link, it's as if the composable image doesn't support lisp. Anyways, it's OK to undocument it completely then. what do you think?

@flovntp
Copy link
Contributor

flovntp commented Mar 7, 2025

Lisp is maintained and supported by the Nix community, so it's supported by us as we supported Composable Image...
But this means we need to keep how to use Lisp in a P.sh/Upsun project.
Maybe we keep the Lisp.md page, and add a banner on top to let the visitor know that if he wants to use Lisp, he would need to use Composable Image.
But that's a complete revamp of the Lisp pages.
invoking @Kemi-Elizabeth here :D

@danmilon
Copy link
Contributor Author

danmilon commented Mar 7, 2025

Yeah nix can support the world, but the list of runtimes is curated by us cause support has to be added for them. The lisp production use I mentioned is internal, so it's probably OK to undocument, and in the meantime the internal thing will be ported to another runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-fork To build PRs from forks markdown/prose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants