Update StaticUtils#toLowerCase #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyhhuang
approved these changes
Feb 13, 2025
| // These test cases are not extensive since the method is a wrapper around | ||
| // the String#toLowercase() from the JDK. | ||
| assertThat(StaticUtils.toLowerCase("lowerstring")).isEqualTo("lowerstring"); | ||
| assertThat(StaticUtils.toLowerCase("sPoNgEbOb tExT")) |
The previous implementation of StaticUtils.toLowerCase() was optimized for ASCII characters. However, this no longer appears to provide a reasonable performance benefit in comparison to passing the call to the JDK. More background on this is available on Jira. Reviewer: vyhhuang Reviewer: dougbulkley JiraIssue: DS-49717
kqarryzada
force-pushed
the
DS-49717-update-lowercase
branch
from
dd5ab0b to
4b1fc5a
Compare
dougbulkley
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of StaticUtils.toLowerCase() was optimized for ASCII characters. However, this no longer appears to provide a reasonable performance benefit in comparison to passing the call to the JDK. More background on this is available on Jira.
Reviewer: vyhhuang
Reviewer: dougbulkley
JiraIssue: DS-49717