tikv-in-memory-engine: Add link to config and extend docs #20293
+62
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
missing-translation-status
dveeden
force-pushed
the
in_memory_link_to_config
branch
from
70a67d5 to
8cd857d
Compare
ti-chi-bot
bot
added
size/M
dveeden
changed the title
qiancai
reviewed
Feb 24, 2025
glossary.md
Outdated
Comment on lines
167
to
169
| ### IME | ||
|
|
||
| The IME abbreviation is for [TiKV MVCC In-Memory Engine](/tikv-in-memory-engine.md). |
There was a problem hiding this comment.
Suggested change
| ### IME | |
| The IME abbreviation is for [TiKV MVCC In-Memory Engine](/tikv-in-memory-engine.md). | |
| ### TiKV MVCC In-Memory Engine (IME) | |
| [TiKV MVCC In-Memory Engine](/tikv-in-memory-engine.md) (IME) caches the latest written MVCC versions in memory and implements an MVCC GC mechanism independent of TiDB to accelerate queries involving a large number of MVCC historical versions. |
There was a problem hiding this comment.
Is the ordering still right if we change this?
There was a problem hiding this comment.
Good catch! After this change, we need to move this term to the ## T section.
Co-authored-by: Grace Cai <qqzczy@126.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
15 tasks
qiancai
reviewed
Feb 24, 2025
Co-authored-by: Grace Cai <qqzczy@126.com>
qiancai
added
translation/done
hfxsd
reviewed
Feb 25, 2025
Comment on lines
+438
to
+441
| - Oldest Auto GC SafePoint: The oldest automatic GC safe point for Regions cached in the in-memory engine | ||
| - Newest Auto GC SafePoint: The newest automatic GC safe point for Regions cached in the in-memory engine | ||
| - Auto GC SafePoint Gap: The time gap between the newest automatic GC safe point and the oldest automatic GC safe point for Regions cached in the in-memory engine | ||
| - Auto GC SafePoint Gap With TiKV: The gap between the TiKV automatic GC safe point and the oldest automatic GC safe point for Regions cached in the in-memory engine |
There was a problem hiding this comment.
Suggested change
| - Oldest Auto GC SafePoint: The oldest automatic GC safe point for Regions cached in the in-memory engine | |
| - Newest Auto GC SafePoint: The newest automatic GC safe point for Regions cached in the in-memory engine | |
| - Auto GC SafePoint Gap: The time gap between the newest automatic GC safe point and the oldest automatic GC safe point for Regions cached in the in-memory engine | |
| - Auto GC SafePoint Gap With TiKV: The gap between the TiKV automatic GC safe point and the oldest automatic GC safe point for Regions cached in the in-memory engine | |
| - Oldest Auto GC SafePoint: The oldest automatic GC safepoint for Regions cached in the in-memory engine | |
| - Newest Auto GC SafePoint: The newest automatic GC safepoint for Regions cached in the in-memory engine | |
| - Auto GC SafePoint Gap: The time gap between the newest automatic GC safepoint and the oldest automatic GC safepoint for Regions cached in the in-memory engine | |
| - Auto GC SafePoint Gap With TiKV: The gap between the TiKV automatic GC safepoint and the oldest automatic GC safepoint for Regions cached in the in-memory engine |
|
|
||
| ### How can I check whether the TiKV MVCC in-memory engine is enabled? | ||
|
|
||
| You can check the TiKV configuration using the [`SHOW CONFIG`](/sql-statements/sql-statement-show-config.md) statement. |
There was a problem hiding this comment.
Suggested change
| You can check the TiKV configuration using the [`SHOW CONFIG`](/sql-statements/sql-statement-show-config.md) statement. | |
| You can check the TiKV configuration using the [`SHOW CONFIG`](/sql-statements/sql-statement-show-config.md) statement. If the value of `in-memory-engine.enable` is `true`, it means that TiKV MVCC in-memory engine is enabled. |
hfxsd
approved these changes
Feb 25, 2025
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
hfxsd
reviewed
Feb 25, 2025
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
|
@dveeden: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?