Skip to content

Commit c2a6586

Browse files
Kevin Wilfongfacebook-github-bot
Kevin Wilfong
authored andcommitted
test: Reenable set_agg and set_union in AggregationFuzzer (facebookincubator#12098)
Summary: Pull Request resolved: facebookincubator#12098 set_agg and set_union were disabled in AggregationFuzzer because Velox and Presto 0.288 had different ordering semantics. This was fixed in 0.289 and we bumped the version of Presto we compare against to 0.290 so this is no longer a concern. Ran a biased AggregationFuzzer run against only set_agg and set_union comparing against Presto for 1 hour and didn't see issues. Reviewed By: spershin Differential Revision: D68286084 fbshipit-source-id: 3a49438467a8fdd64b0a5ef9828058a5ba6f9100
1 parent 4ad5a8a commit c2a6586

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

velox/functions/prestosql/fuzzer/AggregationFuzzerTest.cpp

-7
Original file line numberDiff line numberDiff line change
@@ -132,13 +132,6 @@ int main(int argc, char** argv) {
132132
"map_union_sum",
133133
"approx_set",
134134
"any_value",
135-
// Presto 0.288 makes set_agg and set_union not respect order-by on
136-
// inputs. Presto 0.289
137-
// re-enables the order-by for them. So skip these two functions until we
138-
// compare
139-
// Velox result against Presto 0.289 or later versions.
140-
"set_agg",
141-
"set_union",
142135
};
143136

144137
using facebook::velox::exec::test::ApproxDistinctResultVerifier;

0 commit comments

Comments
 (0)