Skip to content

Commit 4ad5a8a

Browse files
Kevin Wilfongfacebook-github-bot
Kevin Wilfong
authored andcommitted
test: Upgrade the version of Presto we compare fuzzers in CI against to 0.290 (facebookincubator#12096)
Summary: Pull Request resolved: facebookincubator#12096 We currently run Aggregation, Window, and Writer fuzzers comparing against Presto in CI jobs. They run Presto at version 0.288. There are known compatibility issues with this older version, e.g. set_agg and set_union are disabled in AggregationFuzzer because of this. 0.290 appears to be the latest release from Presto and addresses these (we should be able to enable set_agg and set_union after this). I ran the Aggregation, Window, and Writer fuzzers against this version of Presto for an hour and didn't see issues. We also already run AggregationFuzzer against Presto trunk (or close to it) for every PR internally. Reviewed By: kgpai Differential Revision: D68280837 fbshipit-source-id: 74746306d5065d582dc822e5df3cc98e0bc441a0
1 parent 8519fad commit 4ad5a8a

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/docker.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191
tags: "ghcr.io/facebookincubator/velox-dev:adapters"
9292
- name: Presto Java
9393
file: "scripts/prestojava-container.dockerfile"
94-
args: "PRESTO_VERSION=0.288"
94+
args: "PRESTO_VERSION=0.290"
9595
tags: "ghcr.io/facebookincubator/velox-dev:presto-java"
9696
- name: Spark server
9797
file: "scripts/spark-container.dockerfile"

docker-compose.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ services:
9090
image: ghcr.io/facebookincubator/velox-dev:presto-java
9191
build:
9292
args:
93-
- PRESTO_VERSION=0.288
93+
- PRESTO_VERSION=0.290
9494
context: .
9595
dockerfile: scripts/prestojava-container.dockerfile
9696
environment:

scripts/prestojava-container.dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#
1616
FROM ghcr.io/facebookincubator/velox-dev:centos9
1717

18-
ARG PRESTO_VERSION=0.288
18+
ARG PRESTO_VERSION=0.290
1919

2020
ADD scripts /velox/scripts/
2121
RUN wget https://repo1.maven.org/maven2/com/facebook/presto/presto-server/${PRESTO_VERSION}/presto-server-${PRESTO_VERSION}.tar.gz

0 commit comments

Comments
 (0)