Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM 13626 Install perl into pmm client #3766

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from

Conversation

talhabinrizwan
Copy link
Contributor

@talhabinrizwan talhabinrizwan commented Mar 11, 2025

PMM-13626

Link to the Feature Build: SUBMODULES-3863

@talhabinrizwan talhabinrizwan requested review from a team as code owners March 11, 2025 10:32
@talhabinrizwan talhabinrizwan requested review from ademidoff, BupycHuk, idoqo and JiriCtvrtka and removed request for a team March 11, 2025 10:32
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.89%. Comparing base (101aca2) to head (9c79637).

Additional details and impacted files
@@           Coverage Diff           @@
##               v3    #3766   +/-   ##
=======================================
  Coverage   43.89%   43.89%           
=======================================
  Files         367      367           
  Lines       44627    44627           
=======================================
+ Hits        19587    19589    +2     
+ Misses      23356    23354    -2     
  Partials     1684     1684           
Flag Coverage Δ
admin 11.51% <ø> (+0.04%) ⬆️
agent 52.58% <ø> (ø)
managed 45.45% <ø> (ø)
vmproxy 73.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ademidoff ademidoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do better to avoid such issues in the future. I suggest we use the --installroot parameter of dnf install command. This gives at least two benefits:

  1. We don't have to know the exact names of the binaries we need to copy from one stage to another
  2. The resulting image will have much fewer layers, which are too many right now because of multiple COPY --from commands. That will allow to use one COPY command only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants