PMM-13715: allow viewers/editors access limited PMM settings (#3518)

* add new map for failed services * add readonly settings endpoint * update method comment * drop retention data from readonly settings * drop unused fields from settings proto * use separate proto message
percona · Mar 4, 2025 · 51d5ed3 · 51d5ed3
1 parent 2d5003f
commit 51d5ed3
Show file tree

Hide file tree

Showing 15 changed files with 2,261 additions and 315 deletions.
diff --git a/api-tests/server/advisors_test.go b/api-tests/server/advisors_test.go
@@ -52,12 +52,8 @@ func TestStartChecks(t *testing.T) {
 }
 
 func TestGetAdvisorCheckResults(t *testing.T) {
-	if !pmmapitests.RunAdvisorTests {
-		t.Skip("Skipping Advisor tests until we have environment: https://jira.percona.com/browse/PMM-5106")
-	}
-
 	t.Run("with disabled Advisors", func(t *testing.T) {
-		toggleAdvisorChecks(t, true)
+		toggleAdvisorChecks(t, false)
 		t.Cleanup(func() { restoreSettingsDefaults(t) })
 
 		results, err := advisorClient.Default.AdvisorService.GetFailedChecks(nil)

diff --git a/api/server/v1/json/client/server_service/get_read_only_settings_parameters.go b/api/server/v1/json/client/server_service/get_read_only_settings_parameters.go