-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-12887 Implemented new PG dashboard. #1563
Conversation
Actually, I have just noted that We can do it now, or as part of future work. Let me know what you think. |
Let's move this dashboard to the Experimental Folder first, so we can show it to more people while working on improving it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
targeted folder -> Experimental
Moved dashboard to Experimental directory |
}, | ||
{ | ||
"datasource": { | ||
"type": "prometheus", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change such Datasources to
"datasource": "Metrics",
There are multiple occurrences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Yash! Thanks for the review. Please check the new commits.
}, | ||
"yaxes": [ | ||
{ | ||
"$$hashKey": "object:636", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all the hashkey objects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Yash! Thanks for the review. Please check the new commits.
Changed occurrences of "datasource": \{\n\s*"type": "prometheus",\n\s+"uid": "\$\{DS_METRICS\}"\n\s+\}
Changed occurrences of "datasource": \{\n\s*"type": "prometheus",\n\s+"uid": "[0-9A-Za-z]+"\n\s+\}
* PMM-12887 Implemented new PG dashboard. * PMM-12887 Moved dashboard to experimental dir * PMM-12887 removed hashKey objects. * PMM-12887 Refactor datasource to Metrics Changed occurrences of "datasource": \{\n\s*"type": "prometheus",\n\s+"uid": "\$\{DS_METRICS\}"\n\s+\} * PMM-12887 Refactor datasource to Metrics Changed occurrences of "datasource": \{\n\s*"type": "prometheus",\n\s+"uid": "[0-9A-Za-z]+"\n\s+\} --------- Co-authored-by: Roman Novikov <roma.novikov@percona.com>
New dashboard as showcased in https://www.percona.com/blog/postgresql-checkpoints-buffers-and-wal-usage-with-percona-monitoring-and-management/.
We don't need a custom exporter anymore, because we are using pg_stat_replication_pg_current_wal_lsn_bytes, which is being exported in the latest PMM client versions.