Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12887 Implemented new PG dashboard. #1563

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Conversation

guriandoro
Copy link
Contributor

New dashboard as showcased in https://www.percona.com/blog/postgresql-checkpoints-buffers-and-wal-usage-with-percona-monitoring-and-management/.

We don't need a custom exporter anymore, because we are using pg_stat_replication_pg_current_wal_lsn_bytes, which is being exported in the latest PMM client versions.

@guriandoro
Copy link
Contributor Author

Actually, I have just noted that pg_stat_replication_pg_current_wal_lsn_bytes won't work for standalone environments. It seems we can't avoid adding a new exporter for it...

We can do it now, or as part of future work. Let me know what you think.

@rnovikovP
Copy link
Contributor

Let's move this dashboard to the Experimental Folder first, so we can show it to more people while working on improving it.

Copy link
Contributor

@rnovikovP rnovikovP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

targeted folder -> Experimental

@guriandoro
Copy link
Contributor Author

Moved dashboard to Experimental directory

@guriandoro guriandoro requested a review from rnovikovP February 2, 2024 19:01
},
{
"datasource": {
"type": "prometheus",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change such Datasources to
"datasource": "Metrics",

There are multiple occurrences

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yash! Thanks for the review. Please check the new commits.

},
"yaxes": [
{
"$$hashKey": "object:636",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all the hashkey objects

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yash! Thanks for the review. Please check the new commits.

Changed occurrences of "datasource": \{\n\s*"type": "prometheus",\n\s+"uid": "\$\{DS_METRICS\}"\n\s+\}
Changed occurrences of "datasource": \{\n\s*"type": "prometheus",\n\s+"uid": "[0-9A-Za-z]+"\n\s+\}
@rnovikovP rnovikovP merged commit bba499c into percona:main Feb 22, 2024
6 of 7 checks passed
YashSartanpara1 pushed a commit that referenced this pull request Feb 26, 2024
* PMM-12887 Implemented new PG dashboard.

* PMM-12887 Moved dashboard to experimental dir

* PMM-12887 removed hashKey objects.

* PMM-12887 Refactor datasource to Metrics
Changed occurrences of "datasource": \{\n\s*"type": "prometheus",\n\s+"uid": "\$\{DS_METRICS\}"\n\s+\}

* PMM-12887 Refactor datasource to Metrics
Changed occurrences of "datasource": \{\n\s*"type": "prometheus",\n\s+"uid": "[0-9A-Za-z]+"\n\s+\}

---------

Co-authored-by: Roman Novikov <roma.novikov@percona.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants