EVEREST-107: automate veneer update during release #343
Conversation
There was a problem hiding this comment.
Thanks Michal for implementing the changes! Left some comments.
Tips and tricks to test the pipelines:
- Define env variables like this instead of using the github input values directly, it allows to substitute them easily to a hardcoded values during testing.
- Create a separate branch for tests from your feature branch to not mess things up. In that branch CI file:
a) add the push events to the "on" section for your test branch:
on:
push:
branches:
- test-automate-veneer-update
so the workflow will run every time you push smth to the branch.
b) delete all non-related parts of the pipeline so that it would run faster and only the part you'd like to test.
c) comment out all push commands (to github or to dockerhub) so that the CI wouldn't change the actual repos state (you can always print out the git repo state using echo command). But if you still push something, do not forget to clean it up manually.
d) Redefine the constants from section 1 to some hardcoded value you'd like to test.
e) Commit and push, the pipeline will run.
ghost
force-pushed
the
EVEREST-107-automate-veneer-update
branch
from
1ad0d09 to
124c199
Compare
There was a problem hiding this comment.
Looks good, thank you for the implementation. Tested the new part separately - should work fine. As I mentioned in the DM the only thing is missing is to update the tool on the everest-catalog's side so it wouldn't add
---
at the end of the veneer file, bc otherwise the opm tool can't parse the file correctly with
object '' is missing root schema field
However the current PR does not need any more changes, so I think it could be merged.
ghost
enabled auto-merge (squash)
|
Automate veneer update during a release