Skip to content

Commit

Permalink
Fix error handling in transaction signing
Browse files Browse the repository at this point in the history
  • Loading branch information
willyfromtheblock committed Apr 5, 2024
1 parent a1f80fd commit 828a9b0
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 1 deletion.
1 change: 1 addition & 0 deletions lib/screens/wallet/wallet_sign_transaction.dart
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,7 @@ class _WalletSignTransactionScreenState
? Padding(
padding: const EdgeInsets.symmetric(vertical: 10),
child: Text(
key: const Key('signingError'),
AppLocalizations.instance.translate(
'sign_transaction_signing_failed',
),
Expand Down
24 changes: 23 additions & 1 deletion test_driver/key_new.dart
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ void main() {
await driver.waitFor(find.text('mm5pM9sJzVjsafctQJJrJuhGsw1CTucZ2v'));
});

test('Transaction signing', () async {
test('Transaction signing, success', () async {
await driver.tap(find.byTooltip('Transactions'));
await driver.tap(find.byTooltip('Show menu'));
await driver.runUnsynchronized(
Expand All @@ -150,6 +150,28 @@ void main() {
);
});

test('Transaction signing, fail', () async {
await driver.tap(find.pageBack());
await driver.tap(find.byTooltip('Transactions'));
await driver.tap(find.byTooltip('Show menu'));
await driver.runUnsynchronized(
() async {
await driver.tap(find.text('Sign Transaction'));
},
);
await driver.tap(find.text('Select'));
await driver.tap(find.text('mm5pM9sJzVjsafctQJJrJuhGsw1CTucZ2v'));
await driver.tap(find.pageBack());
await driver.tap(find.byValueKey('transactionHexInput'));
await driver.enterText(
'xxx',
);
await driver.tap(find.text('Sign'));
await driver.waitFor(
find.byValueKey('signingError'),
);
});

test('Change wallet title', () async {
await driver.tap(find.pageBack());
await driver.tap(find.byTooltip('Transactions'));
Expand Down

0 comments on commit 828a9b0

Please sign in to comment.