Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockblock and code formatting #3

Merged
merged 4 commits into from
Oct 13, 2017
Merged

Dockblock and code formatting #3

merged 4 commits into from
Oct 13, 2017

Conversation

mos3abof
Copy link
Contributor

  • Added docblock comments to all classes, methods, and traits
  • Code formatted all PHP files.

Resolves issue #2: #2

Dockblock and code formatting
c64e0b6 
- Added docblock comments to all classes, methods, and traits
- Code formatted all PHP files.

Resolves issue pckg#2: pckg#2
@schtr4jh
Copy link
Member

Hi @mos3abof,

thanks for contribution! May I ask you to reformat code with 4 spaces instead of tab? If using Phpstorm simply set code standards to scheme PSR1/2 and reformat again. This way is impossible to review changes.

Regards and thanks again!

@mos3abof
Copy link
Contributor Author

@schtr4jh, sure. I will do that later today.

@mos3abof
Copy link
Contributor Author

@schtr4jh, converted all tabs to spaces.

@schtr4jh schtr4jh merged commit 84b730f into pckg:master Oct 13, 2017
@schtr4jh
Copy link
Member

@mos3abof Thanks, I've merged your changes to master. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mos3abof @schtr4jh