Changes to time and custom partition tests #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed duplicate time partition load test updated custom partition single event test to use 1 field
nitisht
reviewed
Feb 23, 2025
| @@ -658,55 +658,6 @@ func TestLoadStreamBatchWithCustomPartitionWithK6(t *testing.T) { | |||
| DeleteStream(t, NewGlob.QueryClient, customPartitionStream) | |||
| } | |||
|
|
|||
| func TestLoadStreamBatchWithTimePartitionWithK6(t *testing.T) { | |||
There was a problem hiding this comment.
this is passing, why remove this?
There was a problem hiding this comment.
there is another test with a different name - TestLoadHistoricalStreamBatchWithK6, so removed this one
| func TestLoadStreamNoBatchWithTimeAndCustomPartitionWithK6(t *testing.T) { | ||
| if NewGlob.Mode == "load" { | ||
| customPartitionStream := NewGlob.Stream + "timeandcustompartition" | ||
| customHeader := map[string]string{"X-P-Custom-Partition": "level,os", "X-P-Time-Partition": "source_time"} |
There was a problem hiding this comment.
can we switch to customPartition only here
There was a problem hiding this comment.
there is one - TestLoadStreamNoBatchWithCustomPartitionWithK6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove time and custom partition single event test
removed duplicate time partition load test
updated custom partition single event test to use 1 field