Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

도보 예상 시간 분 단위 반환하도록 수정 #79

Merged
merged 2 commits into from
Jun 4, 2024
+6 −13
Merged

도보 예상 시간 분 단위 반환하도록 수정 #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
123cde8
feat: 도보 예상 시간 분 단위 반환하도록 수정
youngh0 Apr 29, 2024
d1d7ebe
출력문 제거
youngh0 Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion domain/src/main/java/com/parkingcomestrue/common/domain/parking/Parking.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public boolean containsPayType(List<PayType> memberPayTypes) {
public int calculateWalkingTime(Location destination) {
double distance = calculateDistanceToDestination(destination);
double averageWalkingTime = distance / AVERAGE_WALKING_SPEED;
return (int) Math.ceil(averageWalkingTime);
return (int) Math.ceil(averageWalkingTime * 60);
}

private double calculateDistanceToDestination(Location destination) {
Expand Down
17 changes: 5 additions & 12 deletions domain/src/test/java/com/parkingcomestrue/common/domain/parking/ParkingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
package com.parkingcomestrue.common.domain.parking;

import com.parkingcomestrue.common.domain.parking.BaseInformation;
import com.parkingcomestrue.common.domain.parking.Fee;
import com.parkingcomestrue.common.domain.parking.FeePolicy;
import com.parkingcomestrue.common.domain.parking.FreeOperatingTime;
import com.parkingcomestrue.common.domain.parking.Location;
import com.parkingcomestrue.common.domain.parking.OperatingTime;
import com.parkingcomestrue.common.domain.parking.Parking;
import com.parkingcomestrue.common.domain.parking.Space;
import com.parkingcomestrue.common.domain.parking.TimeUnit;
import java.util.stream.Stream;
import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.Test;
Expand All @@ -21,7 +12,8 @@ class ParkingTest {
@Test
void 목적지와_68미터_떨어진_주차장_도보_예상시간_계산() {
// given (parking 과 destination 거리 68m)
int expectedTime = (int) Math.ceil(0.068 / 5);
// 0.068 / 5 * 60
int expectedTime = 1;
Parking parking = Parking.builder()
.location(Location.of(127.1215865, 37.4811181))
.build();
Expand All @@ -36,8 +28,9 @@ class ParkingTest {

@Test
void 목적지와_333미터_떨어진_주차장_도보_예상시간_계산() {
// given (parking 과 destination 거리 68m)
int expectedTime = (int) Math.ceil(0.333 / 5);
// given (parking 과 destination 거리 333m)
// 0.333 / 5 * 60
int expectedTime = 5;
Parking parking = Parking.builder()
.location(Location.of(127.1215865, 37.4811181))
.build();
Expand Down
Loading