feat: add accounts/compare endpoint #1597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1591
Adds a new endpoint,
accounts/compare
, that compares up to 30SS58
addresses and determines if they are equal which means that they share the same public key. Returns a boolean result along with detailed information for each address queried.Implementation Notes
The request should be follow one of these formats :
addresses
key:?addresses=...&addresses=...
or?addresses[]=...&addresses[]=...
or?addresses=...,...
.The limit of 30 addresses was set to keep the character count of the request at a reasonable size/not too big.
The additional function
validateAddressQueryParamMiddleware
was added to check that the addresses as query parameters were valid.Sample Request/Response
Example request to check 4 SS58 addresses
Example response
Additional Tests
Tested for:
> 30 addresses