fix: make scripts executable again in benchmark workflow #1589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue #1584 still persists with a different error now from the last PR (#1585) that was merged :
Root cause
The root cause was identified by @alvicsam
This PR changed the permissions of the two scripts found benchmark folder :
generate_benchmark_result.sh
push_benchmark_results.sh
Suggested solution
Based on the recommendation of @alvicsam the files were given executable rights again with :
Additional Fix
Fix in
semantic
workflow sincepull_request_target
is not needed.