Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make scripts executable again in benchmark workflow #1589

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

Imod7
Copy link
Contributor

@Imod7 Imod7 commented Feb 5, 2025

Description

This issue #1584 still persists with a different error now from the last PR (#1585) that was merged :

error: Your local changes to the following files would be overwritten by checkout:
	scripts/ci/benchmarks/generate_benchmark_result.sh
Please commit your changes or stash them before you switch branches.
Aborting
Error: Command 'git' failed with args '-c user.name=github-action-benchmark -c user.email=github@users.noreply.github.com -c http.https://github.com/.extraheader= switch gh-pages': error: Your local changes to the following files would be overwritten by checkout:

Root cause

The root cause was identified by @alvicsam
This PR changed the permissions of the two scripts found benchmark folder :

  • generate_benchmark_result.sh
  • push_benchmark_results.sh

Screenshot 2025-02-05 at 11 11 52

Screenshot 2025-02-05 at 11 11 45

Suggested solution

Based on the recommendation of @alvicsam the files were given executable rights again with :

chmod +x scripts/ci/benchmarks/generate_benchmark_result.sh
chmod +x scripts/ci/benchmarks/push_benchmark_results.sh

Screenshot 2025-02-05 at 11 14 40

Additional Fix

Fix in semantic workflow since pull_request_target is not needed.

@Imod7 Imod7 requested review from a team as code owners February 5, 2025 09:20
- remove unnecessary steps from benchmark workflow
@Imod7 Imod7 changed the title fix: ignore chmod changes in benchmark workflow fix: make scripts executable again in benchmark workflow Feb 5, 2025
@Imod7 Imod7 merged commit 22db863 into master Feb 5, 2025
13 checks passed
@Imod7 Imod7 deleted the domi-fix-bench branch February 5, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants