Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [AHM] - Add AH Next Westend chain #1586

Merged
merged 2 commits into from
Feb 25, 2025
Merged

feat: [AHM] - Add AH Next Westend chain #1586

merged 2 commits into from
Feb 25, 2025

Conversation

Imod7
Copy link
Contributor

@Imod7 Imod7 commented Feb 3, 2025

Description

Part of #1488

One of the initial phases of the Asset Hub Migration process is the addition of the Asset Hub Next Westend chain where a test migration will occur. In this PR we are adding support for this chain to provide a testing environment:

  • for external teams using Sidecar so they can validate their code functionality against the migrated pallets/endpoints.
  • for Sidecar maintainers so they can verify the migrated endpoints functionalities and completeness. This PR can also serve as a template, as the same changes will also be applied to both Kusama and Polkadot migrations.

Code Changes

A new controllers configuration is added for the Asset Hub Next Westend chain called assetHubNextWestendControllers.ts. This Controller is a copy of assetHubWestendControllers.ts file but with the following additional Controllers :

  • from westendControllers:
    • AccountsStakingInfo
    • AccountsStakingPayouts
    • AccountsVestingInfo
    • PalletsNominationPools
    • PalletsStakingProgress
    • PalletsStakingValidators
  • from defaultControllers:
    • PalletsOnGoingReferenda
    • PalletsStorage

The namings & spec-name for the test chain were chosen based on the details and changes found in this PR.

Notes

The Controllers added were chosen based on:

  • the AHM document where the systems (Staking, Governance (including Treasury), Balances) to be migrated are mentioned.
  • the specific pallets mentioned in the list of Pallets with status "Remove from Relay - Setup New on AH" such as pallet_stakingand pallet_vesting.

Testing

In order to test properly & merge this PR, we need to wait until the test chain is live and we have a public endpoint to connect to.

- Sort alphabetically available controllers in other chain-config to check more easily
- Small correction in guide
@filvecchiato filvecchiato self-requested a review February 4, 2025 09:14
@Imod7 Imod7 marked this pull request as ready for review February 25, 2025 12:06
@Imod7 Imod7 requested a review from a team as a code owner February 25, 2025 12:06
Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seadanda
Copy link

Can we merge this ahead of the chain going live or does this need to be timed?

@Imod7
Copy link
Contributor Author

Imod7 commented Feb 25, 2025

Can we merge this ahead of the chain going live or does this need to be timed?

We can merge this ahead of the chain going live. I am merging in a few minutes.

@Imod7 Imod7 merged commit 7217e6e into master Feb 25, 2025
12 checks passed
@Imod7 Imod7 deleted the domi-ah-next branch February 25, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants