Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support httpx >= 0.23.3 for python >= 3.7 #388

Conversation

codenaz
Copy link

@codenaz codenaz commented Sep 15, 2023

When installing this library in a project with httpx 0.24.1, it throws the follwing error

Because no versions of pact-python match >2.0.1,<3.0.0
 and pact-python (2.0.1) depends on httpx (0.23.3), pact-python (>=2.0.1,<3.0.0) requires httpx (0.23.3).
So, because project depends on both httpx (^0.24.1) and pact-python (^2.0.1), version solving failed.

This pull request adds support for higher httpx versions

@JP-Ellis
Copy link
Contributor

Thanks for the PR! Much appreciated.

There's an active PR which is upgrading all of these dependencies (and much more) in #371. If you are happy to wait a little bit, and we should be release a v2.1 soon :) It is currently waiting for further review as it is a rather substantial change.

@codenaz
Copy link
Author

codenaz commented Sep 18, 2023

Thanks for the PR! Much appreciated.

There's an active PR which is upgrading all of these dependencies (and much more) in #371. If you are happy to wait a little bit, and we should be release a v2.1 soon :) It is currently waiting for further review as it is a rather substantial change.

Awesome! I will happily give it a look and perhaps give some feedback. Excited this is happening

@codenaz codenaz closed this Sep 18, 2023
@YOU54F
Copy link
Member

YOU54F commented Sep 19, 2023

Thanks @codenaz for offering the change, and feedback is hugely welcome and greatly appreciated on any of the pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants