Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging robustness #104

Merged
merged 11 commits into from
May 30, 2019
Merged

Improve logging robustness #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
037cc88
Improve logging robustness
lextiz Mar 26, 2019
aab8a5d
Update interaction_replay.rb
lextiz Mar 29, 2019
996a9cc
Initial version of the unit test
lextiz Apr 4, 2019
4c5792a
Move the test to appropriate context
lextiz Apr 4, 2019
a30ebe4
Update interaction_replay_spec.rb
lextiz Apr 4, 2019
2695cd8
Update interaction_replay_spec.rb
lextiz Apr 4, 2019
f607a43
Update interaction_replay_spec.rb
lextiz Apr 4, 2019
b86d6df
Update interaction_replay_spec.rb
lextiz Apr 4, 2019
2524cdb
Update interaction_replay.rb
lextiz Apr 9, 2019
b9916a6
Update interaction_replay_spec.rb
lextiz Apr 9, 2019
e3cd33f
Update interaction_replay_spec.rb
lextiz Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/pact/mock_service/request_handlers/interaction_replay.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ module RequestHandlers
module PrettyGenerate
#Doesn't seem to reliably pretty generate unless we go to JSON and back again :(
def pretty_generate object
JSON.pretty_generate(JSON.parse(object.to_json))
begin
JSON.pretty_generate(JSON.parse(object.to_json))
rescue
object.to_s
end
end
end

Expand Down
12 changes: 12 additions & 0 deletions spec/lib/pact/mock_service/request_handlers/interaction_replay_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,18 @@ module RequestHandlers
end
end
end

context "when the body contains special charachters" do
let(:actual_body) { '\xEB' }

let(:expected_response_body) do
{"message"=>"No interaction found for GET /path", "interaction_diffs"=>[{"body"=>{"ACTUAL"=>"\\xEB", "EXPECTED"=>{"a"=>"body"}}, "description"=>"a request"}]}
end

it "returns the specified response status" do
expect(response_status).to eq 500
end
end
end

context "when no request is found with a matching method and path" do
Expand Down