Avoid updating entity value if the entity is referenced from the new value #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value
Consider the folowing excerpt from a spec file:
```
%global rel 1%{?dist}
Release: %{rel}
```
Previously, calling `Specfile.update_tag("Release", "%rel")` resulted
in the macro definition being updated to `%global rel %rel`, making
the spec file invalid. After this change, the macro definition stays
unchanged and the tag is updated to `Release: %rel`.
Signed-off-by: Nikola Forró <nforro@redhat.com>
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 16s |
|
/packit retest-failed |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 22s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the folowing excerpt from a spec file:
Previously, calling
Specfile.update_tag("Release", "%rel")resulted in the macro definition being updated to%global rel %rel, making the spec file invalid. After this change, the macro definition stays unchanged and the tag is updated toRelease: %rel.