Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrations: update GitHub guides #110

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

stevenrombauts
Copy link
Contributor

This PR updates the GitHub guides for Cloud and Self-Hosted to bring them up to date with the current UI and requirements.

@stevenrombauts stevenrombauts self-assigned this Dec 19, 2024
@stevenrombauts stevenrombauts requested a review from a team December 19, 2024 09:38
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 22%, saving 251.99 KB.

Filename Before After Improvement Visual comparison
Resources/public/img/docs/features/Sync-20241218.png 129.05 KB 102.10 KB -20.9% View diff
Resources/public/img/docs/integration-setup/cloud/github-enterprise-01-packagist-setup.png 147.55 KB 114.43 KB -22.4% View diff
Resources/public/img/docs/integration-setup/cloud/github-enterprise-02-register-app.png 122.09 KB 95.46 KB -21.8% View diff
Resources/public/img/docs/integration-setup/cloud/github-enterprise-04-complete-form.png 93.78 KB 73.84 KB -21.3% View diff
Resources/public/img/docs/integration-setup/cloud/github-enterprise-05-integration.png 67.38 KB 54.69 KB -18.8% View diff
Resources/public/img/docs/integration-setup/github-03-github-credentials.png 134.38 KB 103.52 KB -23.0% View diff
Resources/public/img/docs/integration-setup/self-hosted/github-01-packagist-setup.png 139.39 KB 107.09 KB -23.2% View diff
Resources/public/img/docs/integration-setup/self-hosted/github-02-github-register-app.png 107.88 KB 84.24 KB -21.9% View diff
Resources/public/img/docs/integration-setup/self-hosted/github-04-packagist-form.png 110.10 KB 87.37 KB -20.6% View diff
Resources/public/img/docs/integration-setup/self-hosted/github-05-integrations-overview.png 22.25 KB 17.10 KB -23.2% View diff
Resources/public/img/docs/self-hosted/08-integration.png 70.03 KB 52.05 KB -25.7% View diff

74 images did not require optimisation.

@stevenrombauts stevenrombauts marked this pull request as ready for review December 19, 2024 09:48
Copy link
Member

@glaubinix glaubinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clear and updated screenshots match.

There are two image (github-enterprise-01-..., github-enterprise-03) that you edited in place. I don't fully remember this but I think you might have to change the name to force clear the browser cache

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 20.7%, saving 21.68 KB.

Filename Before After Improvement Visual comparison
Resources/public/img/docs/integration-setup/self-hosted/github-04-packagist-form.png 104.94 KB 83.26 KB -20.7% View diff

84 images did not require optimisation.

@glaubinix glaubinix merged commit 20b2b79 into main Dec 19, 2024
@glaubinix glaubinix deleted the clarify-integration-setup branch December 19, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants