Add arithmetic shift operation #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Shiryaev <w@tagolog.com>
asl
force-pushed
the
mlir-shift-operation
branch
from
8d6ea7c to
b4c67f5
Compare
asl
requested changes
Feb 20, 2025
lib/Dialect/P4HIR/P4HIR_Ops.cpp
Outdated
| "equal the width of the left-hand side operand"; | ||
| } | ||
|
|
||
| if (::mlir::isa<P4HIR::BitsType>(rhsType)) { |
There was a problem hiding this comment.
This could be simplified to:
if (auto rhsBits = mlir::dyn_cast<P4HIR::BitsType>(rhsType)) {
if (rhsBits.isSigned())
return op->emitOpError()
<< "the right-hand side operand of an arithmetic shift must be unsigned";
}Same in other places
tools/p4mlir-translate/translate.cpp
Outdated
| @@ -598,6 +604,16 @@ mlir::Value P4HIRConverter::emitConcatOp(const P4::IR::Concat *concatop) { | |||
| getValue(concatop->right)); | |||
| } | |||
|
|
|||
| mlir::Value P4HIRConverter::emitShlOp(const P4::IR::Shl *op) { | |||
There was a problem hiding this comment.
I do not think we need separate methods for this (at least here, in translator), just emit shift ops in postorder directly.
lib/Dialect/P4HIR/P4HIR_Ops.cpp
Outdated
| "constant; width of left operand of shift needs to be specified or both " | ||
| "operands need to be constant"; | ||
|
|
||
| if (!::mlir::isa<P4HIR::InfIntType>(resultType)) |
There was a problem hiding this comment.
I think we can start with the check that resultType equals to lhsType. This is a common invariant, so it could be hoisted out of conditions.
There was a problem hiding this comment.
See above. I think TypesMatchWith trait will make this check obsolete
asl
reviewed
Feb 20, 2025
| let results = (outs AnyIntP4Type:$result); | ||
| let arguments = (ins AnyIntP4Type:$lhs, AnyIntP4Type:$rhs); | ||
|
|
||
| // Custom builder to infer the result type with the proper width |
There was a problem hiding this comment.
Looks like the comment was just copied from concat and does not make sense here. Also, I think you can use TypesMatchWith to match result type with lhs type.
added 3 commits
February 20, 2025 22:50
… result type. Signed-off-by: Vladimir Shiryaev <w@tagolog.com>
… pull request. Signed-off-by: Vladimir Shiryaev <w@tagolog.com>
… pull request. Get rid of separate emitSh(l/r)Op functions. Signed-off-by: Vladimir Shiryaev <w@tagolog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vladimir Shiryaev w@tagolog.com