Add support for enum & serializable enum types #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 11, 2025
Closed
Closed
asl
force-pushed
the
mlir-enum
branch
2 times, most recently
from
b07eaf9 to
a21c356
Compare
Signed-off-by: Anton Korobeynikov <anton@korobeynikov.info>
Signed-off-by: Anton Korobeynikov <anton@korobeynikov.info>
qobilidop
approved these changes
Feb 24, 2025
| let summary = "serializable enum type"; | ||
| let description = [{ | ||
| Represents an enumeration of values backed by some integer value | ||
| !p4hir.ser.enum<"name", !p4hir.bit<32>, Case1 : 42, Case2 : 0> |
There was a problem hiding this comment.
Nit: This could be discussed later (not blocking merging of this PR). Personally I'd prefer !p4hir.ser_enum over !p4hir.ser.enum.
There was a problem hiding this comment.
Oh, right. Let's rename it right now, so we won't need to update lots of tests later on :)
Signed-off-by: Anton Korobeynikov <anton@korobeynikov.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.