Set up GitHub Actions to build and test P4MLIR #2
Conversation
qobilidop
force-pushed
the
ci-build
branch
2 times, most recently
from
814b5c1 to
d06acab
Compare
|
Let's hope that ccache kicks in on the next commit. This should make it faster. |
Signed-off-by: Bili Dong <qobilidop@gmail.com>
Also configured cache for LLVM. Signed-off-by: Bili Dong <qobilidop@gmail.com>
|
I also added some explicit caching that I learned from: https://github.com/llvm/circt/blob/09f07f5a601a264d69bf6d1c65fcd9a6b067497e/.github/workflows/buildAndTest.yml#L173-L201 I'm not quite sure how ccache works, but maybe these methods complement each other? |
Signed-off-by: Bili Dong <qobilidop@gmail.com>
|
Let's hope. I can see in the actions that both caches have been filled. Let's see how that works out on the next PR. |
|
https://github.com/p4lang/p4mlir/actions/caches These are the caches that have been created. |
|
Do you want to make it mandatory to pass this action for subsequent PRs? |
Yes, I think that's reasonable. Is there a configuration in settings? |
|
|
||
| jobs: | ||
| build-and-test: | ||
| runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Which version of Ubuntu do you want to test for? Ubuntu 22.04 or even 24.04 might be easier.
There was a problem hiding this comment.
For the MLIR part, yes I think these might be better. A while ago I ran into some issues building P4C from source on Ubuntu > 20.04. We'll need to integrate with P4C compilation later. But if that issue is resolved, I agree it's better to test with newer versions of Ubuntu, and maybe a matrix of different OS versions later.
Yes, under "branches". You should also see it. But I just realized this is only possible for public repositories. |
Ah, I see. We can configure this later then. |
No description provided.