Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automerge document module with hard-coded schema #3

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Dec 9, 2024

This module holds the automerge AutoCommit document now with all the necessary methods around it we need.

Additionally this PR uses a hard-coded byte representation to construct the document. This will allow us to independently create documents across peers as all peers will create the same document schema with the same id whenever they do it. More about it here:

https://automerge.org/docs/cookbook/modeling-data/#setting-up-an-initial-document-structure

This module holds the automerge `AutoCommit` document now with all the
necessary methods around it we need.

Additionally this commit prepares the use of a hard-coded byte
representation to construct the document. This will allow us to
independently create documents across peers as all peers will create the
_same_ document schema whenever they do it. More about it here:

<https://automerge.org/docs/cookbook/modeling-data/#setting-up-an-initial-document-structure>
@adzialocha adzialocha changed the title Introduce document module Automerge document module with hard-coded schema Dec 10, 2024
@swick
Copy link
Collaborator

swick commented Dec 10, 2024

LGTM. Any reason this is a draft?

@adzialocha
Copy link
Member Author

LGTM. Any reason this is a draft?

Thank you! I couldn't test it because I don't know yet how to run two separate Aardvark instances on my machine with Builder 🫣

@swick
Copy link
Collaborator

swick commented Dec 10, 2024

Yeah, I just also ran into that issue and I don't know how if there is a nicer way but I can run this:

flatpak build --device=dri --share=network --socket=wayland /var/home/swick/Projects/.gnome-builder/projects/aardvark/flatpak/staging/x86_64-main aardvark

@jonas2515
Copy link
Collaborator

What I did was run a second instance of builder using 'dbus-run-session -- gnome-builder'. For some weird reason it takes about 1 minute until the window actually opens, but then everything works fine.

@adzialocha
Copy link
Member Author

What I did was run a second instance of builder using 'dbus-run-session -- gnome-builder'. For some weird reason it takes about 1 minute until the window actually opens, but then everything works fine.

Great, that worked well for me (also without the 1-minute waiting time)! Thank you!

All tested, seems to be working :-)

@adzialocha adzialocha marked this pull request as ready for review December 10, 2024 21:22
@adzialocha adzialocha merged commit ee60711 into main Dec 10, 2024
4 checks passed
@adzialocha adzialocha deleted the adz/automerge-mod branch December 10, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants