various new 1.85 clippy lints #864
Merged
+33
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the packed structs almost certainly should be repr(C) (why does that default to repr(Rust)???) the indentation change is unfortunate and doc_overindented_list_items hasn't really convinced me that this *would* introduce broken spacing in rendered docs, but i don't have it in me to allow the lint for a few lines like this.
gjcolombo
approved these changes
Feb 20, 2025
|
@gjcolombo it turns out i'd been on the beta channel locally, so i'd updated to 1.86 (!) which does not have a lint present in 1.85 (???) about parenthesizing bitwise operations explicitly, so there are a few more changes here. clippy suggestions are all making the expected operations explicit so it's all pretty straightforward, but mind taking another look? (sorry for the runaround) and yeah, i'll check out VNC while this goes through CI, good call! |
gjcolombo
approved these changes
Feb 20, 2025
hawkw
approved these changes
Feb 20, 2025
|
update: after a slight adventure starting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the packed structs almost certainly should be repr(C) (why does that default to repr(Rust)???)
the indentation change is unfortunate and doc_overindented_list_items hasn't really convinced me that this would introduce broken spacing in rendered docs, but i don't have it in me to allow the lint for a few lines like this.