Bump crucible and update APIs #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftwo
approved these changes
Mar 16, 2024
There was a problem hiding this comment.
So, I've not much experience with using the MaybeUninit stuff, but, from my reading
of their documentation, this seems good.
There is a buch of similar looking kinds of shenanigans going on in this file, so It's
probably best if we have another set of eyes to make sure this is all good.
I say shenanigans in a positive light here :)
pfmooney
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps Crucible to the latest
main. oxidecomputer/crucible#1206 makes some changes to theBlockIO::writeAPI, so it requires minor updates to Propolis as well.