nvme: Expose MDTS value with basic logic #662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luqmana
requested changes
Mar 15, 2024
|
Test notes: I was able to force an illumos guest into issuing a too-large IO in order to observe its rejection from the device. |
luqmana
reviewed
Mar 15, 2024
While the interaction between the block backends and frontends like NVMe could be improved to include negotiation of parameters such as MDTS, it would be nice to define a reasonable value in the mean time.
luqmana
approved these changes
Mar 15, 2024
|
Merged in 6dceb9e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the interaction between the block backends and frontends like NVMe could be improved to include negotiation of parameters such as MDTS, it would be nice to define a reasonable value in the mean time.