PHD: use clap for more cargo xtask phd args
#645
Merged
+222
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `cargo xtask phd` does a bunch of "bash-style" arg parsing, looping over any unrecognized arguments. This was intended as a way of passing through arguments to `phd-runner`. However, because `clap` will stick any unrecognized arguments in `trailing_var_args`, we can just use normal `clap` arg parsing to handle the arguments that we default before passing through to `phd-runner`. Now, the `cargo xtask phd` command has nicer help text for its overridden arguments, and it can use `clap`'s built-in validation of conflicting arguments. This seems nicer.
gjcolombo
reviewed
Feb 15, 2024
gjcolombo
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
cargo xtask phddoes a bunch of "bash-style" arg parsing, looping over any unrecognized arguments. This was intended as a way of passing through arguments tophd-runner. However, becauseclapwill stick any unrecognized arguments intrailing_var_args, we can just use normalclaparg parsing to handle the arguments that we default before passing through tophd-runner.Now, the
cargo xtask phdcommand has nicer help text for its overridden arguments, and it can useclap's built-in validation of conflicting arguments. This seems nicer.