Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nexus] Improve documentation for sled reservation query #7856

Merged
merged 219 commits into from
Mar 25, 2025
Merged

[nexus] Improve documentation for sled reservation query #7856

merged 219 commits into from
Mar 25, 2025

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Mar 21, 2025 •
edited
Loading

This is a follow-up to a request by @gjcolombo to split out some shared queries, and add better docs.

I think cargo fmt committed some crimes here, but the queries here are the same (see: the EXPECTORATE test that guarantees this is true).

smklein added 30 commits January 30, 2025 12:08
@smklein
[nexus] Add Affinity/Anti-Affinity Groups to API (unimplemented)
c9fb7a6
@smklein
[nexus] Add Affinity/Anti-Affinity groups to database
4020517
@smklein
[nexus] Add CRUD implementations for Affinity/Anti-Affinity Groups
8f1d37c
@smklein
[nexus] Consider Affinity/Anti-Affinity Groups during instance placement
772e64f
@smklein
[nexus] Implement Affinity/Anti-Affinity Groups in external API
d8cff32
@smklein
fix policy tests
161f9d6
@smklein
Merge branch 'affinity-db-crud' into affinity-instance-integration
df119b6
@smklein
Merge branch 'affinity-instance-integration' into affinity-integration
83a26a4
@smklein
fmt
8dc0825
@smklein
Merge branch 'affinity-api' into affinity-db-model
e3113ff
@smklein
Merge branch 'affinity-db-model' into affinity-db-crud
789bc97
@smklein
Merge branch 'affinity-db-crud' into affinity-instance-integration
5e21f34
@smklein
Merge branch 'affinity-instance-integration' into affinity-integration
fa9461b
@smklein
tags
4e9cebc
@smklein
doc comments
6cfca2d
@smklein
Merge branch 'affinity-api' into affinity-db-model
a1c97d4
@smklein
Merge branch 'main' into affinity-api
050b4c5
@smklein
typed UUID
4b08032
@smklein
Merge branch 'affinity-api' into affinity-db-model
8bc8f0c
@smklein
Typed UUID
900f09c
@smklein
Merge branch 'affinity-db-model' into affinity-db-crud
195e167
@smklein
Typed UUID
f2ebe31
@smklein
Merge branch 'affinity-db-crud' into affinity-instance-integration
62c38ec
@smklein
Merge branch 'affinity-instance-integration' into affinity-integration
85985c1
@smklein
UUID typing
1326116
@smklein
comments
aba9596
@smklein
Merge branch 'affinity-db-model' into affinity-db-crud
a271f1d
@smklein
review feedback
1ad0101
@smklein
comment
4d26262
@smklein
clippy
6ae1910
@smklein smklein requested review from hawkw and gjcolombo March 21, 2025 18:15
Base automatically changed from affinity-pagination-cleanup to main March 25, 2025 01:35
@smklein smklein enabled auto-merge (squash) March 25, 2025 16:23
@smklein smklein merged commit 24d84b1 into main Mar 25, 2025
16 checks passed
@smklein smklein deleted the affinity-query-commentary branch March 25, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjcolombo gjcolombo gjcolombo approved these changes

@hawkw hawkw Awaiting requested review from hawkw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smklein @gjcolombo