[2/n] store blueprint zone image source in database #7849
+575
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
changed the title
sunshowers
requested review from
andrewjstone,
jgallagher,
plotnick and
davepacheco
|
Ah, I need to update the fake TUF repo generation to ensure that (kind, hash) is actually unique. Moving to draft for now. |
sunshowers
changed the base branch from
main
to
sunshowers/spr/main.wip-store-blueprint-zone-image-source-in-database
sunshowers
changed the title
Created using spr 1.3.6-beta.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in RFD 554, we only store zone image artifact hashes in the database, and look up versions via a left join (so it is allowed to fail).
This lookup requires the kind + hash to be unique, so we add a database and app-level constraint for that, mirroring the constraint implemented in oxidecomputer/tufaceous#16.
Also change
tuf_artifact'sversionfield to 64 bytes per this discussion.Depends on: